fix: extra padding on external results page #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kunatastic @gigincg test failed, the filter and the buttons are still close |
|
Fixed the button's padding
|
|
test approved |
|
@kunatastic please do work on the merge conflict |
|
@khavinshankar @nihal467 fixed the merge conflict. Apologies for long delay |
❌ Deploy Preview Failed. CC: @rithviknishad
|
|
test appproved |
khavinshankar
requested changes
Jun 11, 2022
Comment on lines
418
to
420
| className={`btn btn-primary ${ | ||
| downloadLoading ? "pointer-events-none" : "" | ||
| }`} |
There was a problem hiding this comment.
Suggested change
| className={`btn btn-primary ${ | |
| downloadLoading ? "pointer-events-none" : "" | |
| }`} | |
| className={clsx("btn btn-primary", downloadLoading && "pointer-events-none")} |
can you please use clsx here, it improves the readability and don't forget to import clsx if not already done so
|
@kunatastic check the conflict file ! |
|
@nihal467 this pr is good for testing |
|
test approved |
khavinshankar
requested changes
Jul 6, 2022
|
@kunatastic there are some minor changes, can you please address them |
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
khavinshankar
approved these changes
Jul 6, 2022
khavinshankar
added
good to merge
changes required
and removed
made_changes
good to merge
labels
|
@kunatastic please do work on the merge conflict |
khavinshankar
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2369
Updated UI
