Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: esc keyboard shortcut to close the notification sidebar #2414

Merged
merged 2 commits into from
May 25, 2022
Merged

add: esc keyboard shortcut to close the notification sidebar #2414

merged 2 commits into from
May 25, 2022

Conversation

kunatastic
Copy link
Contributor

fixes #2411

Used useEffect and eventListeners and properly cleaned up the useEffect to avoid additional/overwritten event listeners.

@kunatastic kunatastic requested a review from a team May 18, 2022 07:26
@nihal467
Copy link
Member

test approved

@gigincg gigincg merged commit 743e3d1 into coronasafe:develop May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Esc keyboard shortcut to close the notification sidebar
3 participants
@kunatastic @nihal467 @gigincg