Improve Sample Test page and Voice Recorder #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for dreamy-fermat-b5024e pending review.Visit the deploys page to approve it
|
|
test approved |
|
@Ashesh3 please do work on the merge conflict |
|
@khavinshankar Done! thanks for the ping. |
khavinshankar
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2418
/sample
Previous Hover color:
Updated Hover color:
/sample/<sample_id>
Updated:
Recorder
When the user denies the browser's microphone permission, appropriate message is shown to the user and the recording indicator is stopped. It only works when the user has granted it the required permission.
Side Note:
Seems like the above field is no longer used for a patient, In that case no new patients will have this field displayed on their profile under Sample Test page. Would it be okay to just leave it as it is then?