-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Camera Feed to Tabs in Patient Consultation Page #2487
Conversation
Stuck on an issue with vertical overflow from the camera feed component hence marked as draft till it's fixed. i.mp4 |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
757392 | Google API Key | 2cec8ae | src/Common/env.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@developedBySJ Can you help solve the overflow issue here? |
@gigincg Sure |
Issue is seen when deeply scroll into the page |
❌ Deploy Preview for care-net failed.
|
The overflow problem is fixed from #2758. This PR is good to merge |
@rabilrbl Fix conflicts |
@khavinshankar @gigincg @rabilrbl what is the difference with that existing staging ! |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@nihal467 Camera feed has been moved. Now available under tabs in patient details
|
@rabilrbl does the camera feed button is not redirecting anywhere after this! |
@nihal467 I have tested this in preview. It looks good to me. Check for the patient "Annie Philip" Lets try and merge it this week itself |
@gigincg @khavinshankar Please review this. Lets close this this week |
|
@rabilrbl what is the status ! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@nihal467 All issues are fixed after merging |
test approved |
Closes #2449
Changes
LiveFeed.tsx
) with the new Feed (Feed.tsx
) on the consultation details page.Feed.tsx