Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Camera Feed to Tabs in Patient Consultation Page #2487

Merged
merged 14 commits into from
Aug 11, 2022
Merged

Add Camera Feed to Tabs in Patient Consultation Page #2487

merged 14 commits into from
Aug 11, 2022

Conversation

rabilrbl
Copy link
Contributor

@rabilrbl rabilrbl commented May 22, 2022

Closes #2449

Changes

  • Replace the Old implementation of Feed (LiveFeed.tsx) with the new Feed (Feed.tsx) on the consultation details page.
  • Remove CameraFeed from AppRouter
  • Remove unused variables as shown in ESLint errors in the pre-commit hook
  • Removed unnecessary styling found in Feed.tsx

image

@rabilrbl rabilrbl requested a review from a team May 22, 2022 11:50
@rabilrbl rabilrbl marked this pull request as draft May 22, 2022 11:50
@rabilrbl
Copy link
Contributor Author

rabilrbl commented May 24, 2022

Stuck on an issue with vertical overflow from the camera feed component hence marked as draft till it's fixed.
The camera movement buttons are causing the issue.

@developedBySJ @gigincg

i.mp4

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rabilrbl rabilrbl added the help wanted Extra attention is needed label Jun 29, 2022
@gigincg
Copy link
Member

gigincg commented Jul 4, 2022

@developedBySJ Can you help solve the overflow issue here?

@developedBySJ
Copy link
Contributor

@gigincg Sure

@rabilrbl
Copy link
Contributor Author

rabilrbl commented Jul 7, 2022

@developedBySJ

Issue is seen when deeply scroll into the page

image

@netlify
Copy link

netlify bot commented Jul 7, 2022

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit eb944d3
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62ce307f6b199d0009ec8cd7

@rabilrbl rabilrbl marked this pull request as ready for review July 13, 2022 03:13
@rabilrbl rabilrbl requested a review from a team as a code owner July 13, 2022 03:13
@rabilrbl
Copy link
Contributor Author

The overflow problem is fixed from #2758. This PR is good to merge

@developedBySJ
Copy link
Contributor

@rabilrbl Fix conflicts

@nihal467 nihal467 added question Further information is requested and removed needs testing labels Jul 18, 2022
@nihal467
Copy link
Member

@khavinshankar @gigincg @rabilrbl what is the difference with that existing staging !

@netlify
Copy link

netlify bot commented Jul 18, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 12e2ab1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62ed9e915a63db00086744e7
😎 Deploy Preview https://deploy-preview-2487--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rabilrbl
Copy link
Contributor Author

@nihal467 Camera feed has been moved. Now available under tabs in patient details

Before After
image image

@rabilrbl rabilrbl added needs testing and removed question Further information is requested labels Jul 19, 2022
@nihal467
Copy link
Member

@rabilrbl does the camera feed button is not redirecting anywhere after this!

@aparnacoronasafe
Copy link
Member

@nihal467 I have tested this in preview. It looks good to me. Check for the patient "Annie Philip" Lets try and merge it this week itself

@aparnacoronasafe
Copy link
Member

@gigincg @khavinshankar Please review this. Lets close this this week

@nihal467
Copy link
Member

nihal467 commented Aug 3, 2022

image

@rabilrbl

  • make the page responsive
  • make the button from doctor's note to the top, have same length as of the log update buttons

@nihal467
Copy link
Member

nihal467 commented Aug 3, 2022

@rabilrbl what is the status !

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@rabilrbl
Copy link
Contributor Author

rabilrbl commented Aug 5, 2022

@nihal467 All issues are fixed after merging develop branch!
LMK for any further changes

image

@nihal467
Copy link
Member

nihal467 commented Aug 6, 2022

test approved

@khavinshankar khavinshankar merged commit 37b913f into coronasafe:develop Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera Feed as Tab in Consultation Page
6 participants