-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed improper pagination padding in external results page #2488
Conversation
@GokulramGHV @gigincg deploy preview is failed |
@GokulramGHV @gigincg test failed,
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@GokulramGHV is attempting to deploy a commit to the Coronasafe Team on Vercel. A member of the Team first needs to authorize it. |
❌ Deploy Preview Failed. CC: @rithviknishad
|
@nihal467 I've center aligned the pagination |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
757392 | Google API Key | 2cec8ae | src/Common/env.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@GokulramGHV what is the PR status |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
test approved |
@@ -500,6 +482,16 @@ export default function ResultList() { | |||
</table> | |||
<div className="bg-white divide-y divide-gray-200">{pagination}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the pagination variable was removed, so what are we referring here?
@GokulramGHV what is the status ? |
SonarCloud Quality Gate failed.
|
Fixes #2486
Before:
![image](https://user-images.githubusercontent.com/40627011/169694184-0889d22a-6d0b-442c-9835-bceeb105a976.png)
After:
![image](https://user-images.githubusercontent.com/40627011/169694227-e73efc04-33c2-47d7-a31b-5b5ab0495f50.png)