Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed improper pagination padding in external results page #2488

Merged
merged 10 commits into from
Sep 1, 2022

Conversation

GokulramGHV
Copy link
Member

Fixes #2486

Before:
image

After:
image

@GokulramGHV GokulramGHV requested a review from a team May 22, 2022 12:02
@nihal467
Copy link
Member

@GokulramGHV @gigincg deploy preview is failed

@nihal467
Copy link
Member

wewer

@GokulramGHV @gigincg test failed,

  • the line is missing under the content
  • make the pagination center aligned

@GokulramGHV GokulramGHV requested a review from a team as a code owner June 16, 2022 10:38
@vercel
Copy link

vercel bot commented Jun 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ❌ Failed (Inspect) Jun 16, 2022 at 10:42AM (UTC)

@vercel
Copy link

vercel bot commented Jun 16, 2022

@GokulramGHV is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 7d4f807
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62ab266431bdc3072e4339b4

@GokulramGHV
Copy link
Member Author

@nihal467 I've center aligned the pagination

image

@aeswibon aeswibon added Deploy-Failed Deplyment is not showing preview and removed needs testing labels Jun 23, 2022
@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

@GokulramGHV what is the PR status

@nihal467 nihal467 added the waiting for update PR is been dead for a long time label Jul 31, 2022
@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 158d2e8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/631071f9a7055c00093b75ea
😎 Deploy Preview https://deploy-preview-2488--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@GokulramGHV GokulramGHV added needs testing and removed Deploy-Failed Deplyment is not showing preview waiting for update PR is been dead for a long time labels Aug 4, 2022
@nihal467
Copy link
Member

nihal467 commented Aug 6, 2022

test approved

@@ -500,6 +482,16 @@ export default function ResultList() {
</table>
<div className="bg-white divide-y divide-gray-200">{pagination}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the pagination variable was removed, so what are we referring here?

@khavinshankar khavinshankar added the question Further information is requested label Aug 10, 2022
@nihal467
Copy link
Member

@GokulramGHV what is the status ?

@GokulramGHV GokulramGHV removed the question Further information is requested label Aug 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.0% 6.0% Duplication

@khavinshankar khavinshankar merged commit 53cebf2 into coronasafe:develop Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination padding is improper in external results page
4 participants