Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the unresponsive behaviour of UI in sample test page #2490

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Fixed the unresponsive behaviour of UI in sample test page #2490

merged 4 commits into from
Jun 3, 2022

Conversation

patelaryan7751
Copy link
Contributor

Fixes #2482

Bugs Fixed

1) Fixed Ui of "sample test" page unresponsive behaviour in mobile

video5.mp4

2) Fixed "Update sample test status" modal unresponsive behaviour in mobile

Screenshot from 2022-05-22 18-06-40

@patelaryan7751 patelaryan7751 requested a review from a team May 22, 2022 13:44
@nihal467
Copy link
Member

test approved

khavinshankar
khavinshankar reviewed Jun 3, 2022
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the unused interfaces, variables and functions if they are trivial and tightly coupled (very context specific)

src/Components/Patient/UpdateStatusDialog.tsx Outdated Show resolved Hide resolved
src/Components/Patient/UpdateStatusDialog.tsx Outdated Show resolved Hide resolved
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 3, 2022 04:18
@patelaryan7751
Copy link
Contributor Author

Hey, @khavinshankar I have removed all commented unused variables.

@khavinshankar khavinshankar merged commit c923146 into coronasafe:develop Jun 3, 2022
@patelaryan7751 patelaryan7751 deleted the issue#2482 branch July 14, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ui of "sample test" page unresponsive in mobile
3 participants
@patelaryan7751 @nihal467 @khavinshankar