-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow empty notes and comments #2525
Conversation
Hey @Ashesh3 I found a bug in the shifting page comment posting algorithm we can easily overide the check "Comment should contain 1 character" by giving space . You can view it here #2532 for more detail demonstration. I think we need to also have a check for spaces it might go like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make changes suggested by @patelaryan7751
Fixes #2532 |
test approved |
@Ashesh3 Can you make the Backend issues as well for this? |
Sure, On it! |
Made it here: coronasafe/care#838 |
Fixes #2507
Patient Notes:
![image](https://user-images.githubusercontent.com/3626859/170373498-6fdb06f3-27a3-4919-ba31-691d732e88d0.png)
Resource details page:
![image](https://user-images.githubusercontent.com/3626859/170373567-b8fc3697-5996-478e-947b-911f501e38d3.png)