Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swapped classnames with clsx #2538

Closed
wants to merge 6 commits into from
Closed

swapped classnames with clsx #2538

wants to merge 6 commits into from

Conversation

khavinshankar
Copy link
Member

Fixes #2537

@khavinshankar khavinshankar requested a review from a team May 26, 2022 12:26
@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

nihal467 commented Jul 31, 2022

@khavinshankar what is the status of the PR, ?

@nihal467 nihal467 added the waiting for update PR is been dead for a long time label Jul 31, 2022
@khavinshankar khavinshankar requested a review from a team as a code owner July 31, 2022 13:57
@netlify
Copy link

netlify bot commented Jul 31, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bad1c1d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62e68bad7c1ffc0009380d17
😎 Deploy Preview https://deploy-preview-2538--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 31, 2022

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 6d08832
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62e68a64b5a42700080d5fea

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar
Copy link
Member Author

@nihal467 there is not much to test in this pr, it is more of refactoring going on, it is ready to be merged

@khavinshankar khavinshankar removed the waiting for update PR is been dead for a long time label Jul 31, 2022
@khavinshankar
Copy link
Member Author

closing this pr as this is not relevant anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use clsx instead of classnames
4 participants