Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Facility Image Form (API URL needed) #2543

Closed
wants to merge 18 commits into from
Closed

Added Facility Image Form (API URL needed) #2543

wants to merge 18 commits into from

Conversation

anuran-roy
Copy link
Contributor

This PR addresses Issues #2131 and #2171.

Except the Backend API, other frontend components are ready to be used.

Screenshots:

Before image selection

After image selection

@rithviknishad
Copy link
Member

@anuran-roy deploy preview is failing. merge the latest develop branch.

@rithviknishad
Copy link
Member

@anuran-roy I've cleared cache and triggered deploy. but still it's failing :/
I can also see that you do have the latest develop here...

image

@rithviknishad rithviknishad added the Deploy-Failed Deplyment is not showing preview label Jun 1, 2022
@nihal467
Copy link
Member

@anuran-roy @rithviknishad @gigincg the deploy is still failed

@netlify
Copy link

netlify bot commented Jun 11, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit f7f2e31
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a4a77f19201b00093b79a1

@rithviknishad
Copy link
Member

@anuran-roy @nihal467 deploy fails even after clear cache and deploy.

@anuran-roy anuran-roy requested a review from a team as a code owner June 11, 2022 14:32
@vercel
Copy link

vercel bot commented Jun 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 11, 2022 at 2:34PM (UTC)

@anuran-roy
Copy link
Contributor Author

@nihal467 actually this PR is awaiting the backend changes to be merged by Marmik. It requires an endpoint, which is yet to be added to care backend.

@rithviknishad
Copy link
Member

@gigincg @anuran-roy Vercel preview deploy works without clearing cache out of the box for this PR.
However netlify preview build failed 3 times even after clearing cache.

Build logs says:

8:03:16 PM: Different build command detected, going to use the one specified in the Netlify
configuration file: 'CI='' yarn run build' versus 'CI="" yarn run prebuild && CI="" yarn run
build || { cat /tmp/* ; sleep 30 ; false; }' in the Netlify UI

@nihal467
Copy link
Member

@anuran-roy is it good for testing

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gigincg gigincg reopened this Sep 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gigincg gigincg closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants