Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility page for read-only users improved #2571

Merged
merged 7 commits into from
Jun 2, 2022

Conversation

ishanExtreme
Copy link
Contributor

@ishanExtreme ishanExtreme commented May 28, 2022

Issue Fixed

fixes #2509

Updates

  • Created RoleButton component to render buttons according to role it supports both materalUI and html button.
  • Remove/Disable "Add More Bed Types", "Add Doctor Types", "Add Triage" buttons
  • Remove/Disable "Add Details of a Patient" button
  • Remove/Disable "Update Facility" button
  • Remove/Disable "Create Assets" button
  • Remove/Disable add and update options in "Inventory Management"
  • Remove/Disable "Resource Request" button
  • Remove/Disable all edits option in "Bed Capacity", "Doctors List", "Corona Triage"

Task Pending

  • Remove/Disable add and update options in "Location Management". In this case backend is allowing readOnly user to add location and edit it.

Demo

Corona.Care.-.29.May.2022.mp4

@ishanExtreme ishanExtreme requested a review from a team May 28, 2022 21:11
@ishanExtreme
Copy link
Contributor Author

ReadOnly user credentioal
username: readonly
password: Welcome@123

@nihal467
Copy link
Member

nihal467 commented May 30, 2022

Capture

@ishanExtreme @gigincg test failed, the add patient button is green in the patient tab

@ishanExtreme
Copy link
Contributor Author

@nihal467 I have modified only Facility tab, since there are many pages connected in each tab I will modify other tabs in other PRs

@ishanExtreme
Copy link
Contributor Author

@nihal467 "Add Deatils of patient" button is diabled in facility tab since the ss you shared is patient tab, therefore its not been modified

@nihal467
Copy link
Member

test approved, @ishanExtreme @gigincg what to do with the location management, are we making the backend change

@ishanExtreme
Copy link
Contributor Author

@nihal467 yes I am looking into the care repo to fix this bug

@gigincg
Copy link
Member

gigincg commented May 31, 2022

@nihal467 I have modified only Facility tab, since there are many pages connected in each tab I will modify other tabs in other PRs

That sounds good but, please make an issue listing out all the pages you need to complete (as checklist items), so that we don't accidentally skip out on some pages

Or if the existing issue serves this purpose you can let it be. Also please make the backend issue for the location issue

@khavinshankar
Copy link
Member

@ishanExtreme is this pr good to be merged or is there anything pending that is to be done through this pr?
I see a pending task related to Location Management, so if my understanding is correct that will be handled through a different pr right?

@khavinshankar khavinshankar added the question Further information is requested label Jun 2, 2022
@ishanExtreme
Copy link
Contributor Author

@khavinshankar Yes this PR is good to merge but dont close the issue, I will edit the issue and make another PR once backend is fixed

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khavinshankar khavinshankar added good to merge and removed question Further information is requested labels Jun 2, 2022
@ishanExtreme ishanExtreme requested a review from a team as a code owner June 2, 2022 10:15
@khavinshankar khavinshankar merged commit b9490a3 into coronasafe:develop Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve facility page for read-only users
4 participants