Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "No Medical Found" on patients page & uniformity on Update Patient Page Issue#2585 #2586

Merged
merged 15 commits into from
Jun 10, 2022
Merged

Added "No Medical Found" on patients page & uniformity on Update Patient Page Issue#2585 #2586

merged 15 commits into from
Jun 10, 2022

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented May 30, 2022 •
edited
Loading

Fixes #2585
Screenshot (346)
Screenshot (345)

@Pranshu1902 Pranshu1902 requested a review from a team May 30, 2022 11:43
@nihal467
Copy link
Member

@Pranshu1902 @gigincg deploy preview is failed

developedBySJ
developedBySJ approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rithviknishad
Copy link
Member

@Pranshu1902 deploy preview is failing. merge the latest develop branch.

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed test failed labels May 31, 2022
@rithviknishad rithviknishad added needs testing and removed Deploy-Failed Deplyment is not showing preview labels May 31, 2022
@nihal467
Copy link
Member

nihal467 commented Jun 1, 2022

test failed,
error

  • when we are filling with allergies only, the error occurs
  • reduces the size of no medical
  • is it better to change the "no medical" to "no medical history available". what is your opinion @gigincg

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner June 7, 2022 12:41
@Pranshu1902
Copy link
Contributor Author

Updated view
Screenshot (363)

@netlify
Copy link

netlify bot commented Jun 7, 2022

❌ Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 4510499
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/629f476d0b193c000819e88b

@Pranshu1902
Copy link
Contributor Author

test failed, error

* when we are filling with allergies only, the error occurs

* reduces the size of no medical

* is it better to change the "no medical" to "no medical history available". what is your opinion @gigincg

Is the font better now?

@nihal467
Copy link
Member

nihal467 commented Jun 8, 2022

test approved

@khavinshankar khavinshankar merged commit 01074d1 into coronasafe:develop Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing empty space instead of "No Medical" in the medical section
5 participants
@Pranshu1902 @nihal467 @rithviknishad @khavinshankar @developedBySJ