Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "No Data Found" on Samples Page Issue#2604 #2606

Merged
merged 12 commits into from
Jun 10, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #2604
Screenshot (350)

@Pranshu1902 Pranshu1902 requested a review from a team June 1, 2022 05:52
@nihal467 nihal467 added question Further information is requested work-in-progress and removed needs testing labels Jun 1, 2022
@nihal467
Copy link
Member

nihal467 commented Jun 1, 2022

@Pranshu1902 @gigincg rather than simply putting no data available, put it inside a white box to match with the above UI. @gigincg what do you think

@Pranshu1902
Copy link
Contributor Author

http://localhost:4000/sample/22e36198-0c6c-4ffa-9c0a-3a35aeac684e

Added UI for "No Data Found"
Screenshot (351)

@nihal467
Copy link
Member

nihal467 commented Jun 2, 2022

@Pranshu1902 deployment preview is failed

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed question Further information is requested work-in-progress labels Jun 2, 2022
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Jun 5, 2022
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner June 5, 2022 10:32
@nihal467
Copy link
Member

nihal467 commented Jun 5, 2022

@Pranshu1902 @gigincg can you check the deploy preview

@nihal467 nihal467 added the Deploy-Failed Deplyment is not showing preview label Jun 5, 2022
@netlify
Copy link

netlify bot commented Jun 6, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 8c75a73
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/629e2330892d1d000861dd68

@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Jun 6, 2022
@Pranshu1902
Copy link
Contributor Author

@nihal467 error resolved!

@nihal467
Copy link
Member

nihal467 commented Jun 8, 2022

test approved

@khavinshankar khavinshankar merged commit 9bb1fa5 into ohcnetwork:develop Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nothing visible under "View Sample Report" section
4 participants