Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list without reload on Samples page Issue#2609 #2610

Merged
merged 13 commits into from
Jun 17, 2022

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Jun 1, 2022

Fixes #2609
https://www.loom.com/share/0f81f20ff1f1445999c639212ec888af

  • Updates the list without requiring the user to reload
  • Clears the previous entry in the File name input box

@Pranshu1902 Pranshu1902 requested a review from a team June 1, 2022 06:32
@nihal467
Copy link
Member

nihal467 commented Jun 4, 2022

@Pranshu1902 @gigincg test failed, once the file is uploaded, i need to manually refresh the page to see the uploaded file

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner June 5, 2022 11:25
@nihal467
Copy link
Member

nihal467 commented Jun 8, 2022

@Pranshu1902 @gigincg test failed, when we upload multiple files, the same error occurs, we need to manually reload the page.

Steps to reproduce

  1. upload one file and it works fine by auto-reload
  2. again upload another file, then the auto reload fails

@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit b571a70
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a10af751f1870009d60c67

@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 305f8a7
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a10b45da46740009a038ef

@nihal467
Copy link
Member

test approved

@gigincg gigincg merged commit 8fc7b6e into coronasafe:develop Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reload required to view uploaded files in Sample Report
5 participants