Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed BP Decimal Precision to 2 decimal places #2613

Merged
merged 5 commits into from
Jun 10, 2022
Merged

Fixed BP Decimal Precision to 2 decimal places #2613

merged 5 commits into from
Jun 10, 2022

Conversation

patelaryan7751
Copy link
Contributor

Fixes #2596

Bugs Fixed

Made the values of BP to the precision of 2 Decimal places

video7.mp4

@patelaryan7751 patelaryan7751 requested a review from a team June 1, 2022 13:13
developedBySJ
developedBySJ suggested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks complicated and hard to read.
You can easily round off floats by Math.round(d * 100) / 100

@patelaryan7751
Copy link
Contributor Author

@developedBySJ Is it okay now?

developedBySJ
developedBySJ approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Jun 2, 2022

@patelaryan7751 the deploy preview is failed

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed needs testing labels Jun 2, 2022
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 2, 2022 11:07
@patelaryan7751 patelaryan7751 added needs testing and removed Deploy-Failed Deplyment is not showing preview labels Jun 2, 2022
@patelaryan7751
Copy link
Contributor Author

Hey, @nihal467 the deploy preview is ready now.

@nihal467
Copy link
Member

nihal467 commented Jun 4, 2022

test approved

@khavinshankar khavinshankar merged commit 91a779b into coronasafe:develop Jun 10, 2022
@patelaryan7751 patelaryan7751 deleted the issue#2596 branch July 14, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BP Decimal Precision to 2 decimal
4 participants
@patelaryan7751 @nihal467 @khavinshankar @developedBySJ