Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed App.css and index.scss, moved css imports to index.css #2638

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Removed App.css and index.scss, moved css imports to index.css #2638

merged 2 commits into from
Jun 17, 2022

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Jun 2, 2022 •
edited
Loading

all imports are working properly in index.css,
all styles are now in a single file.
I could see that index.scss was not being used in the entire project so I went ahead and deleted that too.

closes #2603
closes #2602

@skks1212 skks1212 requested a review from a team June 2, 2022 14:56
@skks1212 skks1212 requested a review from a team as a code owner June 2, 2022 14:56
developedBySJ
developedBySJ approved these changes Jun 4, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ishanExtreme
ishanExtreme approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ishanExtreme ishanExtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467 nihal467 added tested question Further information is requested and removed needs testing tested labels Jun 11, 2022
@nihal467
Copy link
Member

powefkowe

@skks1212 @gigincg
the consultation heading tab is misaligned, but it is okay in the current staging, so when this PR is merged, will it affect the UI

@vercel
Copy link

vercel bot commented Jun 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 11, 2022 at 3:33PM (UTC)

@skks1212
Copy link
Member Author

@nihal467 should work now, merged develop

@skks1212 skks1212 added needs testing and removed question Further information is requested labels Jun 11, 2022
@nihal467
Copy link
Member

test approved

@gigincg gigincg merged commit c300ddc into coronasafe:develop Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@ishanExtreme ishanExtreme ishanExtreme approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore using @import statements for all css imports Tailwind: Get rid of the App.css File
6 participants
@skks1212 @nihal467 @khavinshankar @ishanExtreme @developedBySJ @gigincg