Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled dates before previous bed's start date while switching patients bed #2647

Closed
wants to merge 6 commits into from

Conversation

patelaryan7751
Copy link
Contributor

Fixes #2451

Bugs Fixed

Disabled dates before the previous bed's start date while switching the patient's bed. Furthermore, if the selected date is the same as the previous start date it would check for the time if the time selected is after the previous start date's time or not.

video.mp4

@patelaryan7751 patelaryan7751 requested a review from a team June 4, 2022 12:38
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 4, 2022 12:38
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihal467
Copy link
Member

nihal467 commented Jun 5, 2022

test approved

@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 83ec748
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a1e20b0ab31700084aba71

@patelaryan7751
Copy link
Contributor Author

Hey, @developedBySJ I added the min attribute inside the TextInput.

video2.mp4

@nihal467
Copy link
Member

nihal467 commented Jun 11, 2022

@patelaryan7751 @gigincg test failed,

1

I can change the bed, with a future time

@patelaryan7751
Copy link
Contributor Author

Hey, @nihal467 I enquired with @vigneshhari he told me that we can have beds on the same dates but at a future time. The main aim is that we should not allocate beds to one or more patients at the same time.

video91.mp4

@aparnacoronasafe
Copy link
Member

This issue seems resolved in staging

@nihal467 nihal467 added the hold label Jun 22, 2022
@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation: New Bed Assignment should be newer than oldest start time
4 participants