Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Overlapping card headings in Resource Details page #2650

Merged
merged 10 commits into from
Jul 6, 2022

Conversation

naman114
Copy link
Contributor

@naman114 naman114 commented Jun 4, 2022

Fixes #2626

Fixed the overlapping card headings issue in mobile view and made the Resource Details page more responsive

image

image

@naman114 naman114 requested a review from a team June 4, 2022 18:00
@naman114 naman114 requested a review from a team as a code owner June 4, 2022 18:00
@nihal467
Copy link
Member

nihal467 commented Jun 5, 2022

@naman114 @gigincg check the deploy issue

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed needs testing labels Jun 5, 2022
@rabilrbl rabilrbl added needs testing and removed Deploy-Failed Deplyment is not showing preview labels Jun 5, 2022
@nihal467
Copy link
Member

nihal467 commented Jun 8, 2022

4

@naman114 @gigincg test failed, the "Update status/details" button is not responsive and the transfer heading is overlapping with the button

@vercel
Copy link

vercel bot commented Jun 16, 2022

@naman114 is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@naman114
Copy link
Contributor Author

Fixed the responsiveness of the Update status/details button

image

@nihal467
Copy link
Member

1

@naman114 can you remove the white space

@naman114
Copy link
Contributor Author

Converted the cards into a 3 column view to reduce extra white space in desktop view @nihal467

image

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

test approved

@naman114
Copy link
Contributor Author

naman114 commented Jul 4, 2022

Refactored and used clsx for conditional css @khavinshankar

@khavinshankar khavinshankar merged commit 3d96b32 into coronasafe:develop Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping card headings in Resource Details page
4 participants