Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter for working/non-working assets #2651

Closed
wants to merge 14 commits into from

Conversation

siddnikh
Copy link
Contributor

@siddnikh siddnikh commented Jun 5, 2022

Solves #2055

@siddnikh siddnikh requested a review from a team June 5, 2022 18:45
@siddnikh siddnikh requested a review from a team as a code owner June 5, 2022 18:45
@arpancodes arpancodes linked an issue Jun 6, 2022 that may be closed by this pull request
Copy link
Contributor

@Marmik2003 Marmik2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't we using yarn?

@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 9aabf93
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62ea17a94520050008b58265

@nihal467
Copy link
Member

nihal467 commented Jun 8, 2022

2

3

@siddnikh @gigincg test failed, after applying the filter as working, not working asset also coming in the asset

@siddnikh
Copy link
Contributor Author

@nihal467 the backend pull request needs to be merged, first. Here's the PR: coronasafe/care#821

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@siddnikh
Copy link
Contributor Author

siddnikh commented Jul 7, 2022

@nihal467 backend's been done, this is ready for review!

@nihal467
Copy link
Member

@siddnikh
1

check the error and the merge conflict

@nihal467
Copy link
Member

@siddnikh what is the PR status

@nihal467 nihal467 added waiting for update PR is been dead for a long time and removed test failed labels Jul 31, 2022
@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9aabf93
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62ea17a9a4049c0009ee1849
😎 Deploy Preview https://deploy-preview-2651--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@siddnikh siddnikh closed this Aug 3, 2022
@siddnikh siddnikh deleted the issue#2055 branch August 3, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for update PR is been dead for a long time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Filter : Assets
3 participants