Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added spaces on resource page in mobile view #2669

Merged
merged 11 commits into from
Jun 17, 2022
Merged

Added spaces on resource page in mobile view #2669

merged 11 commits into from
Jun 17, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #2666
Screenshot (368)

@Pranshu1902 Pranshu1902 requested a review from a team June 9, 2022 13:30
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner June 9, 2022 13:30
@Pranshu1902 Pranshu1902 changed the title Added spaces on resource page Added spaces on resource page in mobile view Jun 9, 2022
skks1212
skks1212 requested changes Jun 9, 2022
View reviewed changes
Copy link
Member

@skks1212 skks1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same problem occurs in the shifting page too, can you do the same changes there?
Also can you try centering everything?

@nihal467
Copy link
Member

nihal467 commented Jun 9, 2022

@Pranshu1902 @skks1212 is it good for testing

@nihal467 nihal467 added the question Further information is requested label Jun 9, 2022
@skks1212 skks1212 added work-in-progress and removed question Further information is requested labels Jun 9, 2022
@Pranshu1902
Copy link
Contributor Author

@nihal467 I am adding the recommended changes

@netlify
Copy link

netlify bot commented Jun 9, 2022 •
edited
Loading

❌ Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit e08b5fc
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a34a296217ef00081f9396

@Pranshu1902
Copy link
Contributor Author

Shifting page mobile view:
Before:
Screenshot (370)
After:
Screenshot (371)

@nihal467
Copy link
Member

test approved

@gigincg gigincg merged commit fc8d863 into coronasafe:develop Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skks1212 skks1212 skks1212 requested changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons overlap on resources page in mobile view
5 participants
@Pranshu1902 @nihal467 @skks1212 @khavinshankar @gigincg