Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera buttons #2687

Closed
wants to merge 5 commits into from
Closed

Conversation

skks1212
Copy link
Member

closes #2683

@skks1212 skks1212 requested a review from a team June 11, 2022 15:02
@skks1212 skks1212 requested a review from a team as a code owner June 11, 2022 15:02
@vercel
Copy link

vercel bot commented Jun 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 12, 2022 at 5:30PM (UTC)

@netlify
Copy link

netlify bot commented Jun 11, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit ca8db3c
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a6224d2d680c00099e7a2c

@nihal467
Copy link
Member

Screenshot 2022-06-12 161844

@skks1212 @gigincg test failed, to see the full feed-in laptop screen, we need to scroll it, and make it fit the screen size

@skks1212
Copy link
Member Author

skks1212 commented Jun 12, 2022

@nihal467 I have changed the camera feed UI completely, and also added space for the 5 para monitor readings, which will be added in the future. I have removed the aspect ratio class so that the flex could work properly, but it will be of no problem as the video will just show black bars if out of ratio.
image

@skks1212
Copy link
Member Author

Will be changing the UI completely again, thus closing

@skks1212 skks1212 closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera UI button is missing
2 participants