Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an alert when no CSV file is uploaded in Upload External Results Page. #2689

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Jun 12, 2022

Fixes #2678

Bugs

Added an alert when no CSV file is uploaded to Upload External Results Page.

externalupload.mp4

@patelaryan7751 patelaryan7751 requested a review from a team June 12, 2022 06:26
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 12, 2022 06:26
@vercel
Copy link

vercel bot commented Jun 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 2:41AM (UTC)

@netlify
Copy link

netlify bot commented Jun 12, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit a23a4e2
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a5872a84ea190008839d64

@patelaryan7751
Copy link
Contributor Author

Deploy Preview Ready https://deploy-preview-2689--care-net.netlify.app/

Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patelaryan7751 Can you work on UI?
Align the button properly.

@patelaryan7751
Copy link
Contributor Author

Hey @developedBySJ , I have improved the UI
image

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@patelaryan7751 just a suggestion, usually in care we have all of the action buttons to the right especially in forms, so I think it would be better if the button is right aligned instead of the center, 🤔 what do you think?

@khavinshankar khavinshankar added the question Further information is requested label Jun 23, 2022
@patelaryan7751
Copy link
Contributor Author

@patelaryan7751 just a suggestion, usually in care we have all of the action buttons to the right especially in forms, so I think it would be better if the button is right aligned instead of the center, thinking what do you think?

@khavinshankar I think it would look odd as there is only one input field but if you want I can do it :)

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@patelaryan7751 patelaryan7751 removed the question Further information is requested label Jul 4, 2022
@gigincg gigincg merged commit 6fb1eab into coronasafe:develop Jul 7, 2022
@patelaryan7751 patelaryan7751 deleted the issue#2678 branch July 14, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No alert is shown when no CSV file is selected and save button is clicked
7 participants