Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect coorindates validation #2690

Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix incorrect coorindates validation #2690

merged 1 commit into from
Jun 23, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 12, 2022 •
edited
Loading

Closes #2656
Closes #2741

In Facility create / update page...

  • Made latitude to accept values between +/-90.
  • Made longitude to accept values between +/-180.

@rithviknishad rithviknishad requested a review from a team June 12, 2022 17:28
@rithviknishad rithviknishad requested a review from a team as a code owner June 12, 2022 17:28
@vercel
Copy link

vercel bot commented Jun 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 12, 2022 at 5:30PM (UTC)

@netlify
Copy link

netlify bot commented Jun 12, 2022

❌ Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit db78b0c
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a6224153e6440009b59ddf

developedBySJ
developedBySJ approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rithviknishad rithviknishad mentioned this pull request Jun 17, 2022
Closed
@khavinshankar
Copy link
Member

@nihal467 can you test this one out

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 89ba750 into coronasafe:develop Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skks1212 skks1212 skks1212 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to enter longitude above 91 Longitude value doesnot accepts more than 90 and less than -90
5 participants
@rithviknishad @khavinshankar @nihal467 @skks1212 @developedBySJ