Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Patient Summary #2715

Closed
wants to merge 1 commit into from
Closed

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 14, 2022

This change fixes the Summary section on Patient page.

image

Currently it throws an error because consultationId is not placed in the URL.

image

@Ashesh3 Ashesh3 requested a review from a team June 14, 2022 17:29
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 14, 2022 17:29
@vercel
Copy link

vercel bot commented Jun 14, 2022

@Ashesh3 is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@arpancodes arpancodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ashesh3 Ashesh3 mentioned this pull request Jun 21, 2022
@khavinshankar
Copy link
Member

@Ashesh3 This issue has already been fixed in #2729.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jun 23, 2022

@khavinshankar @gigincg Wait, i am a bit confused here.. Wasn't this PR opened before? 😅 It was opened, approved days ago but a newer PR ended up getting merged instead? Am i missing something here? 😅 Just wanna make sure my PRs aren't getting hidden behind.
June 14 this PR and June 17 the other PR

@khavinshankar
Copy link
Member

@Ashesh3 sorry about that, this issue was reported and wanted to be fixed urgent, so when I searched the issues, there was no issue regarding this error, so I kinda went a head and made a pr without searching if there was any pr related to this. 😅

It's my bad, just to be more careful for here on, I suggest creating an issue and assign it to yourself and move a head with pr.

sorry again Ashesh.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jun 23, 2022

@Ashesh3 sorry about that, this issue was reported and wanted to be fixed urgent, so when I searched the issues, there was no issue regarding this error, so I kinda went a head and made a pr without searching if there was any pr related to this. 😅

It's my bad, just to be more careful for here on, I suggest creating an issue and assign it to yourself and move a head with pr.

sorry again Ashesh.

Oh I see, Yep this was indeed an important issue, I agree with you! Thank you for the tip, will create issues for my PRs 😄 And It's all good man! As long as the bugs are resolved, that's what we're here for, right 😉 ! Thanks again!

@Ashesh3 Ashesh3 deleted the fix-summary branch June 23, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants