Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add non-binary gender type to constants #2724

Merged

Conversation

Ritesh-Aggarwal
Copy link
Contributor

This PR fixes an uncaught error which was causing isLoading state to never set to false which caused profile page to get stuck on loading screen ( #2723 ).

@Ritesh-Aggarwal Ritesh-Aggarwal requested a review from a team June 16, 2022 14:12
@Ritesh-Aggarwal Ritesh-Aggarwal requested a review from a team as a code owner June 16, 2022 14:12
@vercel
Copy link

vercel bot commented Jun 16, 2022

@Ritesh-Aggarwal is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@nihal467
Copy link
Member

@Ritesh-Aggarwal
5

unable to create a non-binary gender user

@nihal467
Copy link
Member

@Ritesh-Aggarwal test failed

7

the non-binary is missing from user creation form

@Ritesh-Aggarwal
Copy link
Contributor Author

  • https://care.coronasafe.in/user/add
    There was a discrepancy in GENDER_CHOICES in frontend and backend.
    Now the frontend has been updated to same choices as it is saved in backend. That is "Other" has been changed to "Non-Binary".

@nihal467
Copy link
Member

test approved

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@khavinshankar khavinshankar merged commit 0c1438b into coronasafe:develop Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants