Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'x' icon to close the modal in TeliCUI Switch Bed #2727

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Conversation

khavinshankar
Copy link
Member

Fixes #2720

image

@khavinshankar khavinshankar requested a review from a team June 17, 2022 05:33
@khavinshankar khavinshankar requested a review from a team as a code owner June 17, 2022 05:33
@vercel
Copy link

vercel bot commented Jun 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 6:08AM (UTC)

@netlify
Copy link

netlify bot commented Jun 17, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 419a3af
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62ac4ab8fde57232a2fd9f29

Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samholics
Copy link

tested and verified

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gigincg gigincg merged commit 1e8f234 into develop Aug 4, 2022
@khavinshankar khavinshankar deleted the fix#2720 branch November 13, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Close (&times) Button to make the Bed Model more intuitive
6 participants