Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added styling on Patients page Issue#2735 #2736

Merged
merged 36 commits into from
Aug 16, 2022
Merged

Added styling on Patients page Issue#2735 #2736

merged 36 commits into from
Aug 16, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #2735
Added styling for "Consultation History" and "Sample Test History"
Screenshot (388)

@Pranshu1902 Pranshu1902 requested a review from a team June 17, 2022 10:31
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner June 17, 2022 10:31
@vercel
Copy link

vercel bot commented Jun 17, 2022

@Pranshu1902 is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jun 17, 2022 •
edited
Loading

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 9ec7e2a
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62e0eaf8f0ed940008806529

@vercel
Copy link

vercel bot commented Jun 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 11:18AM (UTC)

@rithviknishad
Copy link
Member

rithviknishad commented Jun 17, 2022 •
edited
Loading

netlify build failing even after clear cache.
vercel deploy seems to work though.
@gigincg @nihal467

developedBySJ
developedBySJ approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed needs testing labels Jun 22, 2022
@gigincg
Copy link
Member

gigincg commented Jun 23, 2022

@Pranshu1902 Can you merge the latest develop?

@gigincg gigincg added changes required and removed Deploy-Failed Deplyment is not showing preview labels Jun 23, 2022
@nihal467
Copy link
Member

@Pranshu1902 still doesn't look good, can you take an opinion from others by posting it in slack

@Pranshu1902
Copy link
Contributor Author

@nihal467
Updated view:
image

@nihal467
Copy link
Member

nihal467 commented Aug 6, 2022

test approved

khavinshankar
khavinshankar reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor changes, remove all the empty classNames

src/Components/Patient/SampleTestCard.tsx Outdated Show resolved Hide resolved
src/Components/Patient/SampleTestCard.tsx Outdated Show resolved Hide resolved
src/Components/Patient/SampleTestCard.tsx Outdated Show resolved Hide resolved
Pranshu1902 and others added 3 commits August 11, 2022 12:56
@Pranshu1902 @khavinshankar
Update src/Components/Patient/SampleTestCard.tsx
98d1215 
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
@Pranshu1902 @khavinshankar
Update src/Components/Patient/SampleTestCard.tsx
6e442df 
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
@Pranshu1902 @khavinshankar
Update src/Components/Patient/SampleTestCard.tsx
47e4678 
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 71fada5 into coronasafe:develop Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

@aeswibon aeswibon aeswibon approved these changes

Assignees
No one assigned
Labels
good to merge peer-reviewed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styling is missing on Patients page
7 participants
@Pranshu1902 @rithviknishad @gigincg @nihal467 @khavinshankar @developedBySJ @aeswibon