Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oxygen description table on facility page #2789

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

kunatastic
Copy link
Contributor

@kunatastic kunatastic commented Jun 20, 2022

closes #2782

  • Responsive table
  • Avoided MUI

Updated UI
image

@kunatastic kunatastic requested a review from a team June 20, 2022 17:14
@kunatastic kunatastic requested a review from a team as a code owner June 20, 2022 17:14
@nihal467
Copy link
Member

@kunatastic

8

under the table, it feels like, it is having double line. is there something we can do ?

@kunatastic
Copy link
Contributor Author

Cool I will fix this

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@kunatastic
Copy link
Contributor Author

@nihal467 this PR is good for testing

@nihal467
Copy link
Member

nihal467 commented Jul 4, 2022

test approved

@khavinshankar khavinshankar merged commit 922f6db into coronasafe:develop Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oxygen information text overflowing on the facility page
6 participants