Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment issue of Patient Page #2836

Merged
merged 6 commits into from
Jul 15, 2022
Merged

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jun 24, 2022

Updates

@aeswibon aeswibon requested a review from a team June 24, 2022 09:51
@aeswibon aeswibon requested a review from a team as a code owner June 24, 2022 09:51
@nihal467
Copy link
Member

nihal467 commented Jun 25, 2022

@cp-Coder test failed, the alignment issue of heading is for all the pages starting from the facilities tab to user management, make the heading stationery, than moving from one position to another on each pages

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

@cp-Coder check the merge conflict !

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

15
15a

@cp-Coder the page is not aligned properly, compare the alignment with the white box at the bottom and fixed the position. Make a uniform position throughout all page

If the white box is short, increase the size of the white box on required pages to match with the heading alignment.

NB: Check for all the tabs

@nihal467
Copy link
Member

nihal467 commented Jul 6, 2022

28

@cp-Coder little bit more aligning to be done all all pages, kindly check it

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar added the merge conflict pull requests with merge conflict label Jul 13, 2022
@aeswibon aeswibon added made_changes and removed merge conflict pull requests with merge conflict labels Jul 14, 2022
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cp-Coder is the changes in other files (other than patients page) intentional?

@khavinshankar khavinshankar added question Further information is requested and removed made_changes labels Jul 15, 2022
@aeswibon
Copy link
Member Author

@cp-Coder test failed, the alignment issue of heading is for all the pages starting from the facilities tab to user management, make the heading stationery, than moving from one position to another on each pages

@khavinshankar Yep. In the above comment, nihal told to make all the alignment stationary. That's why I have made those changes

@aeswibon aeswibon removed the question Further information is requested label Jul 15, 2022
@khavinshankar khavinshankar merged commit 5b3e919 into coronasafe:develop Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource & Shifting Page : Revamp List View Fix Position & Font for Heading
3 participants