Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed patient details section for read-only user 🥁 #2843

Closed
wants to merge 5 commits into from

Conversation

ishanExtreme
Copy link
Contributor

Issue fixed

closes #2636

Updates

for route facility/facilityID/patient/patientID(Patient Details)
Credentails->readonly:Welcome@123

  • Disabled "Post Notes" for read-only users
  • Disabled "Update Sample Test Status" button for read-only users

Note ✨

"Something went wrong" will be currenly displayed in patient details section, PR for fixing this issue is already made in backend
#871(backend).This issue is because read-only staffs are not permitted to GET list of sample tests, read this issue.
Its safe to merge this PR before backend is merged

@ishanExtreme ishanExtreme requested a review from a team June 24, 2022 11:12
@ishanExtreme ishanExtreme requested a review from a team as a code owner June 24, 2022 11:12
Copy link
Member

@aeswibon aeswibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar added the merge conflict pull requests with merge conflict label Jul 13, 2022
@nihal467
Copy link
Member

@ishanExtreme what is the status of PR

@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 2467cd7
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63071a9d1c5b680009e721c3

@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ead0341
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63071f45214bc200085cef18
😎 Deploy Preview https://deploy-preview-2843--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This reverts commit 2467cd7, reversing
changes made to 21bc2c5.
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 48 Code Smells

No Coverage information No Coverage information
10.8% 10.8% Duplication

@khavinshankar khavinshankar removed tested merge conflict pull requests with merge conflict labels Aug 25, 2022
@khavinshankar
Copy link
Member

@ishanExtreme can you please check this pr once and make the necessary changes?

@ishanExtreme
Copy link
Contributor Author

@khavinshankar sorry for delay, onto fixing the PR

@ishanExtreme
Copy link
Contributor Author

@khavinshankar PR updated to this #3485. I am closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve patient details section for read-only users
4 participants