Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Malfunctioning of Asset Creation Page and revamped it's UI #2848

Merged
merged 9 commits into from
Jul 26, 2022

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Jun 24, 2022

Fixes #2841
Fixes #2842

Bugs Fixed

  • Now the asset type is by default shown as "select" you need to choose the asset type then you can proceed

video2.mp4

  • Now when you click on the button the drop list gets generated

video3.mp4

Revamped the asset creation form UI

image

@patelaryan7751 patelaryan7751 requested a review from a team June 24, 2022 18:25
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 24, 2022 18:25
Copy link
Member

@aeswibon aeswibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patelaryan7751 patelaryan7751 changed the title Fixed Malfunctioning of Asset Creation Page Fixed Malfunctioning of Asset Creation Page and revamped it's UI Jun 24, 2022
@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

@patelaryan7751

8

  • replace the location place with this three-button
  • Change the is working heading to Working Status and create a droplist similar to assets where it asks working and not working
  • make it fittable in a laptop screen and avoid scrolling on the page

@nihal467
Copy link
Member

@patelaryan7751 what is the status

@patelaryan7751
Copy link
Contributor Author

@nihal467 i am working on it my laptop had crashed

@netlify
Copy link

netlify bot commented Jul 21, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f9cd313
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62dfa7f0ea10110009610238
😎 Deploy Preview https://deploy-preview-2848--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patelaryan7751
Copy link
Contributor Author

Hey, @nihal467 I have done the changes

asset manage

@nihal467
Copy link
Member

test approved

src/Components/Facility/AssetCreate.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp Asset Creation Form Asset Creation Form Malfunction
4 participants