Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made The shifting page board responsive #2866

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

patelaryan7751
Copy link
Contributor

Fixes #2826

Bugs Fixed

Made The shifting page board responsive in iPad

  • iPad Air
    image
  • iPad Mini
    image

@patelaryan7751 patelaryan7751 requested a review from a team June 24, 2022 21:04
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 24, 2022 21:04
Copy link
Member

@aeswibon aeswibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Jun 25, 2022

@patelaryan7751 test failed, the issue still the same with galaxy fold

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@patelaryan7751
Copy link
Contributor Author

@nihal467 Now it is responsive in Samsung fold I guess
image

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

test approved

@khavinshankar khavinshankar merged commit 7aaf12a into coronasafe:develop Jul 6, 2022
@patelaryan7751 patelaryan7751 deleted the issue#2826 branch July 14, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shifting page is unresponsive
4 participants