Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp bed management page, improve responsiveness #2903

Merged
merged 8 commits into from
Jul 14, 2022

Conversation

naman114
Copy link
Contributor

Fixes #2745

  • Revamped the design of the Bed Management page
  • Replaced the existing table with a list view to improve responsiveness on mobile screens
  • Created a separate route to edit a bed's details, replacing the current method of updating the values in the table itself

Before

image
image

Now

2022-06-26.20-13-14.mp4

@naman114 naman114 requested a review from a team June 26, 2022 14:48
@naman114 naman114 requested a review from a team as a code owner June 26, 2022 14:48
@naman114 naman114 changed the title Feat: revamp bed management page, improve responsiveness Revamp bed management page, improve responsiveness Jun 26, 2022
@aeswibon
Copy link
Member

aeswibon commented Jun 27, 2022

Fixes #2838

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

@naman114

1

having the badge on the top. waste a lot of space, can we have an alternate location for the badge

@naman114
Copy link
Contributor Author

naman114 commented Jul 4, 2022

I've moved the Bed Type tag next to the Bed Name. How does this look? @nihal467

image

@nihal467
Copy link
Member

nihal467 commented Jul 6, 2022

32

@naman114 the alignment of the both bottom feel like too much low, can you bring it up a bit

@naman114
Copy link
Contributor Author

naman114 commented Jul 6, 2022

Fixed the vertical alignment of the buttons @nihal467

image

@nihal467
Copy link
Member

nihal467 commented Jul 6, 2022

test approved

@khavinshankar
Copy link
Member

image

@naman114 the text seems to be overflowing in md screens, truncate might help

please add need testing after the fix

@naman114 naman114 mentioned this pull request Jul 9, 2022
@naman114
Copy link
Contributor Author

Fixed the overflowing title text on md screens @khavinshankar

image

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit db18d17 into coronasafe:develop Jul 14, 2022
This was referenced Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bed management page is not mobile responsive
4 participants