-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect behaviour of back button in Add patient by external results page #2919
Fix incorrect behaviour of back button in Add patient by external results page #2919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rithviknishad When we click on import from external results
we get directed to the URL ..patient?extId=
but when we click on the back button we are still on the same URL. Because of that, we have to click twice on the back button to go back to the previous page.
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
757392 | Google API Key | 2cec8ae | src/Common/env.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
tested, verified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #2918
Steps:
Go to https://deploy-preview-2919--care-net.netlify.app/facility/551f9e09-04a3-4f52-ade2-1db45588741d/patient
Click Import from External Results
![image](https://user-images.githubusercontent.com/25143503/175902538-98d7baa4-3db7-43df-8861-e078ddc8d98e.png)
Press Back button
![image](https://user-images.githubusercontent.com/25143503/175902627-a2d5dbf6-44c4-4aa8-a88b-3c3395a219a2.png)