Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error message on 429 status code #2946

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 30, 2022

Fixes #2938
This change displays the error message before returning the error response.

image

@Ashesh3 Ashesh3 requested a review from a team June 30, 2022 08:41
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 30, 2022 08:41
@nihal467
Copy link
Member

nihal467 commented Jul 2, 2022

10

@Ashesh3 captcha is not working

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jul 2, 2022

10

@Ashesh3 captcha is not working

The Recaptcha keys are for a specific domains only, The error stated in the screenshot explains itself. If they site-key permits itself to be used on the domain you are testing the site on, it would work, otherwise Recaptcha will fail to render. I tested it on localhost and it seems localhost is in allowed domains.

This PR has nothing to do with the way Recaptcha renders, all it changes is just src/Redux/fireRequest.tsx to display the error before returning the response.

The domain you are running this test on, needs to be added in the domains section of the google Recaptcha page where you generated the API key.

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

test approved

@khavinshankar khavinshankar merged commit 091e041 into coronasafe:develop Jul 6, 2022
@Ashesh3 Ashesh3 deleted the fix-2938 branch July 6, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit message not shown on login page
5 participants