Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: delete specialization doctor type #2953

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

kunatastic
Copy link
Contributor

closes #2832

2022-07-01.16-31-21.mp4

Added the delete button directly on facilty page because

  1. The edit form was being re-used at several places
  2. Now, both the edit and delete option are at same location

@kunatastic kunatastic requested a review from a team July 1, 2022 11:06
@kunatastic kunatastic requested a review from a team as a code owner July 1, 2022 11:06
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunatastic

When I delete all items, it does not show "No Doctors Found".
image

However, when I refresh the page only it shows up.
image

@kunatastic
Copy link
Contributor Author

Cool @rithviknishad, on it

@nihal467
Copy link
Member

nihal467 commented Jul 2, 2022

8

@kunatastic now the UI look so lengthy, is there any alternative way to implement the delete button

@kunatastic
Copy link
Contributor Author

Updated UI
image

image

@nihal467 is this better?

@nihal467
Copy link
Member

nihal467 commented Jul 6, 2022

test approved

@khavinshankar khavinshankar merged commit efa6086 into coronasafe:develop Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doctor List in Facility page : Unable to delete
5 participants