Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyled discharge patient popup #2996

Merged
merged 10 commits into from
Jul 21, 2022
Merged

Restyled discharge patient popup #2996

merged 10 commits into from
Jul 21, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #2992
image

@Pranshu1902 Pranshu1902 requested a review from a team July 3, 2022 10:29
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner July 3, 2022 10:29
aeswibon
aeswibon reviewed Jul 3, 2022
View reviewed changes
Copy link
Member

@aeswibon aeswibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

@Pranshu1902 the combination of red and green doesn't look good, can you change it to something suitable to the UI

developedBySJ
developedBySJ reviewed Jul 3, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this for reference
modals

@nihal467 @gigincg

@Pranshu1902
Copy link
Contributor Author

@nihal467 Updated UI:
image

@nihal467
Copy link
Member

nihal467 commented Jul 6, 2022

@Pranshu1902 give a border for the cancel button too,

@Pranshu1902
Copy link
Contributor Author

Updated view:
image

@nihal467
Copy link
Member

nihal467 commented Jul 6, 2022

@Pranshu1902 reduce the grey intensity, its shadow effect, of the button

@Pranshu1902
Copy link
Contributor Author

@nihal467 is this ok?
image

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar added the merge conflict pull requests with merge conflict label Jul 14, 2022
@Pranshu1902 Pranshu1902 removed the merge conflict pull requests with merge conflict label Jul 14, 2022
@Pranshu1902
Copy link
Contributor Author

Updated view:
image

@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@netlify
Copy link

netlify bot commented Jul 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b9c0a40
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62d27e1f93176b0009732958
😎 Deploy Preview https://deploy-preview-2996--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khavinshankar khavinshankar merged commit 0d5ad0a into coronasafe:develop Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developedBySJ developedBySJ developedBySJ left review comments

@aeswibon aeswibon aeswibon left review comments

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
made_changes tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp : Discharge Pop-up
5 participants
@Pranshu1902 @nihal467 @khavinshankar @developedBySJ @aeswibon