Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation when updating facility #3015

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jul 5, 2022

Fixes #3014

Since the fields, "district", "state", "local_body" and "ward" are numerical values with the default (non selected) value being 0, it should be casted as a number before the validation check is done.

image

image

image

@Ashesh3 Ashesh3 requested a review from a team July 5, 2022 22:01
@Ashesh3 Ashesh3 requested a review from a team as a code owner July 5, 2022 22:01
@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 6f090c1 into coronasafe:develop Jul 13, 2022
@Ashesh3 Ashesh3 deleted the fix-3014 branch July 21, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility update page validation issue
5 participants