Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Add Bed Capacity and Exit button #3054

Merged
merged 11 commits into from
Jul 27, 2022
Merged

Added Add Bed Capacity and Exit button #3054

merged 11 commits into from
Jul 27, 2022

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Jul 8, 2022 •
edited
Loading

@Pranshu1902 Pranshu1902 requested a review from a team July 8, 2022 09:12
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner July 8, 2022 09:12
GokulramGHV
GokulramGHV reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@GokulramGHV GokulramGHV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranshu1902 The field validation errors are not shown when the 'Save bed capacity' button is clicked.

Screencast-from-08-07-22-03_10_04-PM-IST

@Pranshu1902
Copy link
Contributor Author

@Pranshu1902 The field validation errors are not shown when the 'Save bed capacity' button is clicked.

Screencast-from-08-07-22-03_10_04-PM-IST Screencast-from-08-07-22-03_10_04-PM-IST

resolved

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@Pranshu1902 please do remove the button in the update form
image

@Pranshu1902
Copy link
Contributor Author

@Pranshu1902 please do remove the button in the update form image

done

@netlify
Copy link

netlify bot commented Jul 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c4664af
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62e0f1a92d4b86000950195a
😎 Deploy Preview https://deploy-preview-3054--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@Pranshu1902 make the page responsive

@Pranshu1902
Copy link
Contributor Author

@nihal467
Mobile view:
image

@nihal467
Copy link
Member

image

@Pranshu1902 make the button full, in responsivity, so that they are aligned to the fields such as currently occupied

@Pranshu1902
Copy link
Contributor Author

@nihal467
Updated view:
image

@nihal467
Copy link
Member

test approved

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 950c378 into ohcnetwork:develop Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivankacker shivankacker shivankacker approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@GokulramGHV GokulramGHV GokulramGHV approved these changes

@aeswibon aeswibon aeswibon approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a save and exit button on Add Bed Capacity page
6 participants
@Pranshu1902 @nihal467 @khavinshankar @shivankacker @GokulramGHV @aeswibon