New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed notification issue in Facility Form #3098

Merged

khavinshankar merged 3 commits into coronasafe:develop from aeswibon:issue#3044

Jul 21, 2022

Member

aeswibon commented Jul 10, 2022

Updates

Fixes Facility Form : Malfunction #3044
Fixed notification logic for Facility Form

aeswibon requested a review from a team

July 10, 2022 07:31

aeswibon requested a review from a team as a code owner

July 10, 2022 07:31

aeswibon added the needs testing label

skks1212 approved these changes

View reviewed changes

skks1212 added the peer-reviewed label

Ashesh3 requested changes

View reviewed changes

Member

Ashesh3 left a comment

Minor change, otherwise LGTM

src/Components/Facility/FacilityCreate.tsx Outdated Show resolved Hide resolved

Member

nihal467 commented Jul 11, 2022 •

edited

Loading

@cp-Coder make the notification more user friendly

nihal467 added work-in-progress and removed needs testing labels

aeswibon and others added 2 commits

July 20, 2022 13:26


          Fixed notification logic for facility form

725ab0e


          Update src/Components/Facility/FacilityCreate.tsx

0ca6601

Co-authored-by: Ashesh <3626859+Ashesh3@users.noreply.github.com>

Member Author

aeswibon commented Jul 20, 2022

@nihal467 This error is not present anymore.
If a user tries to assign 0: Choose Ward as a ward, it will show Field is required. The form will not be saved.

aeswibon added needs testing and removed work-in-progress labels


          Removing duplicate code

c67e711

aeswibon force-pushed the issue#3044 branch from f9bc7ac to c67e711 Compare

July 20, 2022 08:08

netlify bot commented Jul 20, 2022 •

edited

Loading

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`c67e711`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/62d7b7ea74fb04000cda64c8
😎 Deploy Preview	https://deploy-preview-3098--care-egov-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sonarcloud bot commented Jul 20, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Member

nihal467 commented Jul 20, 2022

test approved

nihal467 added tested and removed needs testing labels

khavinshankar approved these changes

View reviewed changes

khavinshankar merged commit 97176f8 into coronasafe:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment