Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added truncate in breadcrumbs on mobile view #3137

Merged
merged 9 commits into from
Aug 3, 2022
Merged

Added truncate in breadcrumbs on mobile view #3137

merged 9 commits into from
Aug 3, 2022

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Jul 15, 2022 •
edited
Loading

@Pranshu1902 Pranshu1902 requested a review from a team July 15, 2022 08:31
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner July 15, 2022 08:31
@netlify
Copy link

netlify bot commented Jul 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7ddc888
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62e3a67d317ccc0008c222bd
😎 Deploy Preview https://deploy-preview-3137--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Pranshu1902
Copy link
Contributor Author

Updated view:
image

developedBySJ
developedBySJ approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

@Pranshu1902
image

unable to see the breadcrumbs in mobile view ( galaxy fold )

@Pranshu1902
Copy link
Contributor Author

@Pranshu1902 image

unable to see the breadcrumbs in mobile view ( galaxy fold )

I didn't get it, the breadcrumbs are visible in the screenshot, please elaborate what's the error

@nihal467
Copy link
Member

@Pranshu1902
image

the breadcrumbs makes the page lengthy, can we do anything regarding that !

@Pranshu1902
Copy link
Contributor Author

@nihal467
Updated view:
image

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Aug 3, 2022

test approved

@khavinshankar khavinshankar merged commit c5d7285 into coronasafe:develop Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

@aeswibon aeswibon aeswibon approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumbs extend beyond screen in mobile view
5 participants
@Pranshu1902 @nihal467 @khavinshankar @developedBySJ @aeswibon