Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed malfunction in user management #3152

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Fixed malfunction in user management #3152

merged 2 commits into from
Jul 28, 2022

Conversation

aeswibon
Copy link
Member

Updates

@aeswibon aeswibon requested a review from a team July 15, 2022 14:59
@aeswibon aeswibon requested a review from a team as a code owner July 15, 2022 14:59
@netlify
Copy link

netlify bot commented Jul 15, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e7e446a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62d5361c2646070008fbd80f
😎 Deploy Preview https://deploy-preview-3152--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

developedBySJ
developedBySJ suggested changes Jul 18, 2022
View reviewed changes
src/Components/Users/ManageUsers.tsx Outdated Show resolved Hide resolved
src/Components/Users/ManageUsers.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

developedBySJ
developedBySJ approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

@cp-Coder
image

Even though the user is logged out 5 minutes ago, it is saying online

@aeswibon
Copy link
Member Author

@nihal467 I have tested this on another user. I didn't encounter the problem mentioned above.

Ashesh3
Ashesh3 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor optional change, otherwise LGTM!

src/Components/Users/ManageUsers.tsx Show resolved Hide resolved
@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 1384b48 into coronasafe:develop Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

@tomahawk-pilot tomahawk-pilot Awaiting requested review from tomahawk-pilot

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Management Malfunction
5 participants
@aeswibon @nihal467 @Ashesh3 @khavinshankar @developedBySJ