Fixed malfunction in user management regarding add user form #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
test approved |
khavinshankar
approved these changes
Jul 27, 2022
Comment on lines
+267
to
+277
| if (userIndex <= USER_TYPES.indexOf("StateAdmin")) { | ||
| setStates([ | ||
| ...initialStates, | ||
| { | ||
| id: currentUser.data.state, | ||
| name: currentUser.data.state_object.name, | ||
| }, | ||
| ]); | ||
| } else { | ||
| setStates([...initialStates, ...statesRes.data.results]); | ||
| } |
There was a problem hiding this comment.
@cp-Coder @gigincg wouldn't the condition always be true and hence the else block is never executed.
userIndex is an index within USER_TYPES, and StateAdmin is the last element in USER_TYPES and hence it has the highest index. so...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates