Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the consultation form responsive for Samsung Fold Device #3175

Closed
wants to merge 5 commits into from
Closed

Made the consultation form responsive for Samsung Fold Device #3175

wants to merge 5 commits into from

Conversation

patelaryan7751
Copy link
Contributor

Fixes #3148

Made the consultation form responsive for Samsung Fold Device

consultation form

@patelaryan7751 patelaryan7751 requested a review from a team July 21, 2022 07:27
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner July 21, 2022 07:27
@netlify
Copy link

netlify bot commented Jul 21, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4ef9430
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62e91bf682eae700082ebeb7
😎 Deploy Preview https://deploy-preview-3175--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

developedBySJ
developedBySJ suggested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrate to tailwind CSS buttons.

@patelaryan7751
Copy link
Contributor Author

Hey, @developedBySJ I have migrated the buttons to tailwind.

@nihal467
Copy link
Member

@developedBySJ after review, provide the comment

@patelaryan7751
Copy link
Contributor Author

@developedBySJ I have done the changes.

@nihal467
Copy link
Member

nihal467 commented Aug 2, 2022 •
edited
Loading

@patelaryan7751 can you merge the latest version of care and update the label to need testing

@patelaryan7751
Copy link
Contributor Author

@nihal467 done.

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@nihal467
Copy link
Member

nihal467 commented Aug 3, 2022

@patelaryan7751
image

make it responsive

@patelaryan7751 patelaryan7751 mentioned this pull request Aug 13, 2022
Closed
@Ritesh-Aggarwal
Copy link
Contributor

Hey @patelaryan7751 , why was this PR closed, Is there any other PR fixing #3148 ?

@patelaryan7751
Copy link
Contributor Author

Hey actually i tried to fix it the ui changed so i unassigned it
@Ritesh-Aggarwal

@patelaryan7751
Copy link
Contributor Author

You can work on it it is not fixed yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@SandeepThomas SandeepThomas Awaiting requested review from SandeepThomas

@developedBySJ developedBySJ Awaiting requested review from developedBySJ

Assignees
No one assigned
Labels
test failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make consultation update page responsive
5 participants
@patelaryan7751 @nihal467 @Ritesh-Aggarwal @Ashesh3 @developedBySJ