-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Rename WhatsApp number to Alternative number #3184
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@Ashesh3 can you mention the issue? |
They appear to be the same thing. We can set WhatsApp number on the profile page, but in the users page, the filter lists it as "Alternative number" and filtering works displaying it as alt number But the profile page shows it as "WhatsApp" number. The frontend is inconsistent with how the data is stored and represented in the backend. Everywhere, the "second number" is referenced by "Alternative number" and not "WhatsApp number". https://github.com/coronasafe/care/blob/master/care/users/models.py#L216
The filter displays it as "Alternative number" too Updating the said "WhatsApp number" actually sends it as the alternative number: https://github.com/coronasafe/care_fe/blob/develop/src/Components/Users/UserProfile.tsx#L491
The https://github.com/coronasafe/care_fe/blob/develop/src/Components/Users/models.tsx#L12
So, it appears that "WhatsApp number" is actually just the "Alternative number" but mislabeled. |
@Ashesh3 once work is completed, change the badge |
@coronasafe/care-fe-code-reviewers Need your opinion here. |
Todo: After discussing this with @gigincg , The change would be to rename "Alternative number" on the filter page to "WhatsApp number" |
the badge still says, it is alternative number , where everywhere else it is WhatsApp no |
Kudos, SonarCloud Quality Gate passed!
|
@nihal467 Fixed! |
test approved |
The secondary phone number for a user is referenced as "Alternative number" throughout the code and also in the users filter.
In order to make it more user friendly and consistent, WhatsApp number should be labelled as "Alternative number" instead.
![image](https://user-images.githubusercontent.com/3626859/180319540-2317b548-8acb-479c-85fb-ec2209226d4c.png)