Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed facility feature placement and added a generic tooltip component #3185

Merged
merged 7 commits into from
Aug 4, 2022
Merged

Changed facility feature placement and added a generic tooltip component #3185

merged 7 commits into from
Aug 4, 2022

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Jul 22, 2022 •
edited
Loading

closes #3176
image

@skks1212 skks1212 requested a review from a team July 22, 2022 04:03
@skks1212 skks1212 requested a review from a team as a code owner July 22, 2022 04:03
@netlify
Copy link

netlify bot commented Jul 22, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit cb4fb92
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62e92b83d98bcc00090ff9d2
😎 Deploy Preview https://deploy-preview-3185--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@skks1212
image

the UI is not looking good, is there a alternative approach to it ?

@nihal467 nihal467 added question Further information is requested work-in-progress and removed needs testing labels Jul 26, 2022
@skks1212
Copy link
Member Author

skks1212 commented Jul 26, 2022 •
edited
Loading

@skks1212 image

the UI is not looking good, is there a alternative approach to it ?

@nihal467 I don't think there is any other approach to this other than tooltips... do you have any suggestions?

@skks1212 skks1212 changed the title Added facility tooltip Changed facility feature placement and added a generic tooltip component Jul 29, 2022
@skks1212 skks1212 added needs testing and removed question Further information is requested work-in-progress labels Jul 29, 2022
@nihal467
Copy link
Member

nihal467 commented Aug 1, 2022

test approved

@netlify
Copy link

netlify bot commented Aug 2, 2022

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 4d6b787
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62e92008cd8d560008e9f830

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@gigincg gigincg merged commit b61ba7f into coronasafe:develop Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@gigincg gigincg gigincg approved these changes

@aeswibon aeswibon aeswibon approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

@developedBySJ developedBySJ Awaiting requested review from developedBySJ

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facility Faetures
7 participants
@skks1212 @nihal467 @Ashesh3 @gigincg @khavinshankar @developedBySJ @aeswibon