-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix check for required fields on Update Patient Details page #3200
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ashesh3
If you change
state => reset district, local_body, ward
district => reset local_body, ward
local_body => reset ward
Currently, only one field is updated
Hey, the field updating is chained in the current logic. I agree that updating all children fields at once would be neater, making the change now. Edit: Tried using a fall though switch case but |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@Ashesh3 @developedBySJ once completed, change the status to need testing |
The requested changes are made from my side and it works as expected. Need a review @developedBySJ then testing. |
The requested changes are done, need a test now! |
@developedBySJ do the review and upon completed, update the label to need testing, currently making it to work-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test approved |
Fixes #3181
When a parent selection changes, the dependent option is reset to the "Unselected" choice. This PR also fixes the check for blank selection, by casting it to a number first as they are stored as string.