Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messages when deletion fails #3213

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jul 23, 2022

Fixes #3212

Some deletion endpoints have no feedback if the deletion fails. This PR fixes it.

image

@Ashesh3 Ashesh3 requested a review from a team July 23, 2022 15:31
@Ashesh3 Ashesh3 requested a review from a team as a code owner July 23, 2022 15:31
@Ashesh3 Ashesh3 requested a review from mathew-alex July 23, 2022 15:31
@netlify
Copy link

netlify bot commented Jul 23, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 88e9d93
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62de406b7fa1140008239289
😎 Deploy Preview https://deploy-preview-3213--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor code and optional chaining operator

src/Components/Facility/BedManagement.tsx Outdated Show resolved Hide resolved
src/Components/Facility/Consultations/LiveFeed.tsx Outdated Show resolved Hide resolved
src/Components/ExternalResult/ResultItem.tsx Outdated Show resolved Hide resolved
src/Components/Facility/FacilityUsers.tsx Outdated Show resolved Hide resolved
src/Components/Resource/ResourceDetails.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@nihal467
Copy link
Member

test approved

Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khavinshankar khavinshankar merged commit ac6714a into coronasafe:develop Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete a facility
6 participants