Fix Notification suppression logic #3218

Ashesh3 · 2022-07-24T07:05:18Z

There are minor issues in the way fireRequest decides when to suppress error notifications.
It was recently changed in da40a71

suppressNotif? : true,
This defines an optional parameter suppressNotif which has a type of true | undefined. This is not the intended behavior. It should rather be a parameter named suppressNotif of type Boolean which defaults to false. false because the old behavior of the CARE platform was not to suppress these errors unless explicitly specified. It seems that the below logic does keep that old behavior but the variable usage is confusing.

Changed to suppressNotif = false
if (suppressNotif && error.response) {
This is a confusing use of the variable suppressNotif. In this case, if suppressNotif is true (We want to suppress error messages), it will actually end up showing the error messages, and if it is false (we want to show the error messages), it actually hides all the error messages.

Changed to if (!suppressNotif && error.response) {
export const getUserDetails = (username: string, suppress? : true) => {
This again defines an optional parameter suppress which has a type of undefined | true, instead it should be a Boolean parameter with default value of true
Changed to export const getUserDetails = (username: string, suppress = true) => {

netlify · 2022-07-24T07:06:48Z

Name	Link
🔨 Latest commit	`fb3eb77`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/62e561d7465e35000a5f7d56
😎 Deploy Preview	https://deploy-preview-3218--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.