Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved UX in file upload #3225

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Improved UX in file upload #3225

merged 1 commit into from
Jul 27, 2022

Conversation

GokulramGHV
Copy link
Member

Fixes #3224

Changes:

  • Removed autofilling on "File Name" Text box in file upload
  • Added an error notification when upload button is pressed when no file is selected
  • Cleared the file input after each upload so that the user dosen't accidently upload the same file again

Preview:

fileupload.mp4

@GokulramGHV GokulramGHV requested a review from a team July 25, 2022 16:06
@GokulramGHV GokulramGHV requested a review from a team as a code owner July 25, 2022 16:06
@netlify
Copy link

netlify bot commented Jul 25, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f98d21c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62debf83b6e8e200098458b6
😎 Deploy Preview https://deploy-preview-3225--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 9181b83 into coronasafe:develop Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@aeswibon aeswibon aeswibon approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Upload UX
4 participants
@GokulramGHV @nihal467 @khavinshankar @aeswibon