Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Clear assigned doctor #3228

Merged
merged 10 commits into from
Sep 8, 2022
Merged

Fix: Clear assigned doctor #3228

merged 10 commits into from
Sep 8, 2022

Conversation

GokulramGHV
Copy link
Member

Fixes #3227

  • Fixed: unable to clear the existing assigned doctor and keep it blank

@GokulramGHV GokulramGHV requested a review from a team July 26, 2022 04:58
@GokulramGHV GokulramGHV requested a review from a team as a code owner July 26, 2022 04:58
@GokulramGHV GokulramGHV requested a review from gigincg July 26, 2022 04:58
@netlify
Copy link

netlify bot commented Jul 26, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6a77425
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6318e45a3e06ea000828daf6
😎 Deploy Preview https://deploy-preview-3228--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@GokulramGHV @developedBySJ
Update src/Components/Facility/ConsultationForm.tsx
9c2455e 
Co-authored-by: Swapnil J <76519654+developedBySJ@users.noreply.github.com>
@nihal467
Copy link
Member

@GokulramGHV once work is completed, change the label

@GokulramGHV
Copy link
Member Author

@nihal467 The work is completed

@nihal467
Copy link
Member

@GokulramGHV when we click clear, the droplist appears, can we avoid that!

@nihal467 nihal467 added question Further information is requested and removed needs testing labels Jul 27, 2022
@GokulramGHV
Copy link
Member Author

@nihal467 I've made the changes..

@GokulramGHV GokulramGHV added needs testing and removed question Further information is requested labels Aug 1, 2022
@nihal467
Copy link
Member

nihal467 commented Aug 2, 2022

image

@GokulramGHV make it responsive

@nihal467
Copy link
Member

nihal467 commented Aug 7, 2022

@GokulramGHV
image

the clear button is covered in responsive, any better place

@nihal467 nihal467 added the question Further information is requested label Aug 7, 2022
@GokulramGHV
Copy link
Member Author

@nihal467 is this okay?
Screenshot from 2022-08-12 12-24-19

@GokulramGHV GokulramGHV removed the question Further information is requested label Aug 12, 2022
@nihal467
Copy link
Member

@GokulramGHV can you put a cross button and try it out, rather than keeping a button saying clear?

@GokulramGHV
Copy link
Member Author

@nihal467 Is this ok?
image

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@developedBySJ can you please rereview this one?

@khavinshankar khavinshankar added needs review merge conflict pull requests with merge conflict and removed needs review labels Aug 19, 2022
@GokulramGHV GokulramGHV removed the merge conflict pull requests with merge conflict label Aug 25, 2022
@nihal467 nihal467 added Cypress Test Pending The Cypress test are to be verified and removed tested labels Sep 5, 2022
@nihal467
Copy link
Member

nihal467 commented Sep 5, 2022

@GokulramGHV merge the latest development branch and check it passes the cypress test or not

@nihal467 nihal467 added the tested label Sep 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gigincg gigincg merged commit 6268a39 into coronasafe:develop Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

@developedBySJ developedBySJ Awaiting requested review from developedBySJ

Assignees
No one assigned
Labels
Cypress Test Pending The Cypress test are to be verified tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemedicine Malfunction
5 participants
@GokulramGHV @nihal467 @khavinshankar @developedBySJ @gigincg